chore(IAccountManager): remove deprecated visibility constants #52544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
requested review from
come-nc,
skjnldsv,
sorbaugh and
yemkareems
and removed request for
a team and
sorbaugh
come-nc
approved these changes
May 5, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Small coding style issue, otherwise nice 👍
susnux
force-pushed
the
chore/drop-deprecated-account-scopes
branch
from
ef0d5e8 to
9f795db
Compare
sorbaugh
approved these changes
May 13, 2025
skjnldsv
approved these changes
May 14, 2025
susnux
force-pushed
the
chore/drop-deprecated-account-scopes
branch
from
9f795db to
37d3519
Compare
Those constants are not used anywhere anymore and are deprecated for more than ten versions. So its time to cleanup the interface. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/drop-deprecated-account-scopes
branch
from
37d3519 to
1b273b8
Compare
susnux
added a commit
to nextcloud/documentation
that referenced
this pull request
May 15, 2025
…ty constants * for nextcloud/server#52544 Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added a commit
to nextcloud/documentation
that referenced
this pull request
May 15, 2025
…ty constants * for nextcloud/server#52544 Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
removed
the
pending documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Those constants are not used anywhere anymore and are deprecated for more than ten versions.
All legacy scopes should be already migrated as this was done since Nextcloud 21.
Checklist