fix: Remove unneccesary etag check

[SystemKeeper]

• Resolves: ETag check of /navigation/apps not working #52278

Summary

The etag check is neither useful (as the computation is already done at that point), nor is it working correctly.

[kesselb]

If it would work, we should save a few bytes by not retransferring something the client already has 😉

[SystemKeeper]

If it would work, we should save a few bytes by not retransferring something the client already has 😉

But it works already, because we set the etag on the response object, and then it is handled in https://github.com/nextcloud/server/blob/master/lib/private/AppFramework/Middleware/NotModifiedMiddleware.php ? The only advantage of doing it manually would be to save computation, if I can generate the etag, without retrieving/building the data, but that is not the case here, the processing happens always.

The PHPUnit tests are failing, because we don't wire up the middleware (and also the header name needs to be changed), like in

server/tests/lib/AppFramework/Middleware/NotModifiedMiddlewareTest.php

Lines 28 to 30 in f26dc79

	$this->middleWare = new NotModifiedMiddleware(
	$this->request
	);

.
But IMO we should just remove the tests, as we are otherwise just testing what the middleware-test already tests!?

[kesselb]

as we are otherwise just testing what the middleware-test already tests!?

Yes. It would be nice though to keep a modified version of the test to assert that the logout url is ignored. According to #8652 (comment) that url changes and is therefore excluded.

[kesselb]

It's super weird to return the logout url in the api response. The requesttoken is bound to the current session and therefore will not work somewhere else 🤷

[SystemKeeper]

@kesselb That's what you had in mind?