Skip to content

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented May 4, 2025

Enforce the correct value type when setting a config (via occ) defined in the Lexicon:

$ ./occ config:app:set my_app enable_something --value 'not_a_boolean'

In SetConfig.php line 194:
                                                        
  Value is not a boolean, please use 'true' or 'false'  

@ArtificialOwl ArtificialOwl requested a review from a team as a code owner May 4, 2025 23:20
@ArtificialOwl ArtificialOwl requested review from come-nc, icewind1991 and sorbaugh and removed request for a team May 4, 2025 23:20
@ArtificialOwl ArtificialOwl added this to the Nextcloud 32 milestone May 4, 2025
@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label May 4, 2025
@come-nc
Copy link
Contributor

come-nc commented May 5, 2025

There were 14 failures:

@ArtificialOwl ArtificialOwl force-pushed the feat/noid/get-value-type-from-lexicon branch from ed19fc6 to b3f52eb Compare May 5, 2025 11:17
@ArtificialOwl
Copy link
Member Author

There were 14 failures:

my bad, better detection of the presence of an entry in the Lexicon
should be better now

(squashed+pushed)

@ArtificialOwl ArtificialOwl merged commit cd06b24 into master May 7, 2025
229 of 242 checks passed
@ArtificialOwl ArtificialOwl deleted the feat/noid/get-value-type-from-lexicon branch May 7, 2025 01:04
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants