Skip to content

Conversation

@Valdnet
Copy link
Contributor

@Valdnet Valdnet commented May 8, 2025

No description provided.

@Valdnet Valdnet requested a review from a team as a code owner May 8, 2025 13:36
@Valdnet Valdnet requested review from nfebe, skjnldsv and susnux and removed request for a team May 8, 2025 13:36
@Valdnet Valdnet added the feature: language/translations (l10n/i18n) Localization and translation matters label May 8, 2025
@Valdnet Valdnet requested review from a team and rakekniven May 8, 2025 13:36
Copy link
Member

@rakekniven rakekniven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't plural being used here as well?
Federated cloud IDs

@skjnldsv
Copy link
Member

skjnldsv commented May 9, 2025

/compile rebase

Valdnet and others added 3 commits May 9, 2025 07:01
@Valdnet
Copy link
Contributor Author

Valdnet commented May 9, 2025

Shouldn't plural being used here as well? Federated cloud IDs

Yes you are right. My oversight.
Thanks for the edit PR.

@skjnldsv skjnldsv merged commit d7f8a10 into master May 9, 2025
121 of 123 checks passed
@skjnldsv skjnldsv deleted the Valdnet-patch-1 branch May 9, 2025 19:21
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants