-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: Cache compiled routes #52793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Cache compiled routes #52793
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ee3abdd
feat(router): Cache routes in local cache if possible
come-nc 01575b7
feat(router): Use Symfony CompiledUrlMatcherDumper to cache routes
come-nc 5c9092b
fix: Use a more fitting cache key
come-nc 216da3a
fix: Deprecate action and actionInclude from routes and fix actionInc…
come-nc 446b22a
feat(router): Add fallback for legacy action and file routes
come-nc 0d78c60
fix: Fix psalm issue by adding missing parameter for profiler
come-nc e8370bf
fix: Use only enabled applications versions in the cache prefix
come-nc a2fdecc
chore(tests): Adapt AppManager test to the use of searchValues
come-nc c6f2eff
fix: Fix log display for integration tests
come-nc 89f51a8
chore(tests): Add test for AppConfig::getAppInstalledVersions
come-nc 12e7f46
fix: Use application ids as well as versions in the cache prefix
come-nc bb485fb
fix: Load all partially enabled apps routes
come-nc ba53147
chore: update psalm baseline
come-nc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
feat(router): Cache routes in local cache if possible
This is not ideal because serializing the routecollection is not easy. It seems Symfony has its own way of doing things by dumping routes to a PHP file, maybe that would be better, but it would mean pulling a new symfony dependency and maybe refactor our Router. Signed-off-by: Côme Chilliet <[email protected]>
- Loading branch information
commit ee3abdd81bc75aa6b373dcc6eec0bdd6aeda0c5a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.