Skip to content

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented May 13, 2025

Summary

Makes it a bit easier to find blocked requests due to rate limiting, similar to what we do for the bfp throttle.

Example user:

{
  "reqId": "HPn5tPcQdhZCCs7LjQ9P",
  "level": 1,
  "time": "2025-05-13T16:59:00+00:00",
  "remoteAddr": "172.18.0.1",
  "user": "bob",
  "app": "no app in context",
  "method": "POST",
  "url": "/ocs/v2.php/apps/files_sharing/api/v1/shares",
  "message": "Request blocked because it exceeds the rate limit [method: OCA\\Files_Sharing\\Controller\\ShareAPIController::createShare, limit: 20, period: 600]",
  "userAgent": "IntelliJ HTTP Client/PhpStorm 2025.1.0.1",
  "version": "32.0.0.0",
  "data": []
}

Example anon:

{
  "reqId": "2kWZvzMS0ECmcf2HdmW8",
  "level": 1,
  "time": "2025-05-13T17:02:06+00:00",
  "remoteAddr": "172.18.0.1",
  "user": "--",
  "app": "no app in context",
  "method": "GET",
  "url": "/index.php/u/alice",
  "message": "Request blocked because it exceeds the rate limit [method: OCA\\Profile\\Controller\\ProfilePageController::index, limit: 5, period: 120]",
  "userAgent": "IntelliJ HTTP Client/PhpStorm 2025.1.0.1",
  "version": "32.0.0.0",
  "data": []
}

Checklist

@kesselb kesselb added this to the Nextcloud 32 milestone May 13, 2025
@kesselb kesselb self-assigned this May 13, 2025
@kesselb kesselb requested a review from a team as a code owner May 13, 2025 17:12
@kesselb kesselb requested review from artonge, provokateurin and sorbaugh and removed request for a team May 13, 2025 17:12
@kesselb kesselb added bug 3. to review Waiting for reviews labels May 13, 2025
@kesselb kesselb force-pushed the bug/noid/log-requests-exceeding-rate-limit branch from a8b29ea to a53e15c Compare May 14, 2025 10:23
@kesselb kesselb enabled auto-merge May 14, 2025 10:23
@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 14, 2025
@kesselb
Copy link
Contributor Author

kesselb commented May 14, 2025

/backport to stable31

@kesselb
Copy link
Contributor Author

kesselb commented May 14, 2025

/backport to stable30

@kesselb kesselb merged commit 7523c38 into master May 14, 2025
194 of 205 checks passed
@kesselb kesselb deleted the bug/noid/log-requests-exceeding-rate-limit branch May 14, 2025 12:54
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants