Skip to content

Conversation

@icewind1991
Copy link
Member

Extracted from #52786 to get smaller, easier to review PRs

Extracts and unifies the handling of primary object store configuration.

As with #52786, this also allows configuring multibucket object storages by settings the multibucket arguments instead of having the configuration under the the objectstore_multibucket key. (it should have never be done like that tbh)

@icewind1991 icewind1991 force-pushed the primary-object-store-settings branch 4 times, most recently from da651df to 56169fd Compare May 14, 2025 13:57
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label May 14, 2025
@icewind1991 icewind1991 added this to the Nextcloud 32 milestone May 14, 2025
@icewind1991 icewind1991 marked this pull request as ready for review May 14, 2025 14:55
@icewind1991 icewind1991 requested a review from a team as a code owner May 14, 2025 14:55
@icewind1991 icewind1991 requested review from Altahrim, artonge and come-nc and removed request for a team May 14, 2025 14:55
@icewind1991 icewind1991 force-pushed the primary-object-store-settings branch from 56169fd to 2c98eea Compare May 14, 2025 18:13
@icewind1991 icewind1991 force-pushed the primary-object-store-settings branch 5 times, most recently from 3ee53a3 to 3567dd1 Compare May 16, 2025 08:42
@icewind1991 icewind1991 force-pushed the primary-object-store-settings branch from 3567dd1 to 7599162 Compare May 28, 2025 13:32
@icewind1991 icewind1991 merged commit be3cfef into master May 28, 2025
217 of 229 checks passed
@icewind1991 icewind1991 deleted the primary-object-store-settings branch May 28, 2025 15:40
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@icewind1991
Copy link
Member Author

/backport to stable31

@icewind1991
Copy link
Member Author

/backport to stable30

@backportbot
Copy link

backportbot bot commented Sep 24, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/52816/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7599162c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52816/stable31

Error: Failed to push branch backport/52816/stable31: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."}
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants