Skip to content

[stable31] fix(files): do not even try to fetch a preview if has-preview is false #52819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
May 27, 2025
Merged

[stable31] fix(files): do not even try to fetch a preview if has-preview is false #52819

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ed1050
fix(files): do not even try to fetch a preview if èhas-preview` is false
skjnldsv May 14, 2025
52ffa36
chore(assets): Recompile assets
nextcloud-command May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): do not even try to fetch a preview if èhas-preview` is false 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
  • Loading branch information
@skjnldsv @AndyScherzinger
skjnldsv authored and AndyScherzinger committed May 26, 2025
commit 4ed1050ccfe657cc5b171f736c6888609f9cc1e9
12 changes: 12 additions & 0 deletions apps/files/src/components/FileEntry/FileEntryPreview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
class="files-list__row-icon-blurhash"
aria-hidden="true" />
<img v-if="backgroundFailed !== true"
:key="source.fileid"
ref="previewImg"
alt=""
class="files-list__row-icon-preview"
Expand Down Expand Up @@ -147,6 +148,17 @@ export default defineComponent({
return null
}

if (this.source.attributes['has-preview'] !== true
&& this.source.mime !== undefined
&& this.source.mime !== 'application/octet-stream'
) {
const previewUrl = generateUrl('/core/mimeicon?mime={mime}', {
mime: this.source.mime,
})
const url = new URL(window.location.origin + previewUrl)
return url.href
}

try {
const previewUrl = this.source.attributes.previewUrl
|| (this.isPublic
Expand Down