fix(settings): Send update request when clearing user manager #52833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
requested review from
artonge,
sorbaugh and
susnux
and removed request for
a team
5 tasks
artonge
reviewed
May 15, 2025
nfebe
force-pushed
the
fix/44492/settings-remove-user-manager
branch
from
4d7ae5c to
a6211ef
Compare
susnux
reviewed
May 15, 2025
Contributor
|
/backport to stable31 |
Contributor
|
/backport to stable30 |
nfebe
changed the title
nfebe
force-pushed
the
fix/44492/settings-remove-user-manager
branch
from
a6211ef to
c54115e
Compare
Contributor
Author
|
/compile |
susnux
reviewed
May 15, 2025
susnux
approved these changes
May 15, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Seems to work, but would feel better to add this to the existing Cypress test.
skjnldsv
reviewed
May 15, 2025
nfebe
force-pushed
the
fix/44492/settings-remove-user-manager
branch
from
7579c09 to
ae54198
Compare
auto-merge was automatically disabled
May 15, 2025 15:49
Pull request was converted to draft
nfebe
force-pushed
the
fix/44492/settings-remove-user-manager
branch
2 times, most recently
from
1227fb0 to
1b8cf38
Compare
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
nfebe
force-pushed
the
fix/44492/settings-remove-user-manager
branch
from
38ad28c to
3d87cfe
Compare
Contributor
Author
|
/compile |
nfebe
force-pushed
the
fix/44492/settings-remove-user-manager
branch
3 times, most recently
from
0b30d13 to
ebb7c4a
Compare
- Update setUserData to send PUT request for empty manager values - Remove clear button from manager select in UserRow - Simplify manager update logic in UserRow - Ensure consistent API behavior for empty values in allowedEmpty fields Signed-off-by: nfebe <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nfebe <[email protected]>
Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/44492/settings-remove-user-manager
branch
from
ebb7c4a to
3e0368e
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
artonge
approved these changes
May 22, 2025
This was referenced May 22, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.