Skip to content

[stable30] fix(files_sharing): Show note if note exists on share #52850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfebe merged 3 commits into from
May 26, 2025
Merged

[stable30] fix(files_sharing): Show note if note exists on share #52850

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd46760
fix(files_sharing): Show note if note exists on share
nfebe May 14, 2025
28ae3d3
test(file_sharing): Do not open advanced settings manually
nfebe May 14, 2025
b7aa85d
chore(assets): Recompile assets
nextcloud-command May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(file_sharing): Do not open advanced settings manually 
If a share note is present, the advanced settings should expand automatically,

without the user needing to click.

Signed-off-by: nfebe <[email protected]>
  • Loading branch information
@nfebe @AndyScherzinger
nfebe authored and AndyScherzinger committed May 26, 2025
commit 28ae3d3038b4136811ad489a66285a166b847e96
3 changes: 1 addition & 2 deletions cypress/e2e/files_sharing/note-to-recipient.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ describe('files_sharing: Note to recipient', { testIsolation: true }, () => {
cy.get('[data-cy-sidebar]').within(() => {
// Open the share
cy.get('[data-cy-files-sharing-share-actions]').first().click()
// Open the custom settings
cy.get('[data-cy-files-sharing-share-permissions-bundle="custom"]').click()

cy.findByRole('checkbox', { name: /note to recipient/i })
.and('be.checked')
Expand All @@ -90,4 +88,5 @@ describe('files_sharing: Note to recipient', { testIsolation: true }, () => {
.and('have.value', 'Hello, this is the note.')
})
})

})
Loading