Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented May 15, 2025

Backport of #51818

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Altahrim, artonge and icewind1991 May 15, 2025 11:43
@backportbot backportbot bot added the 3. to review Waiting for reviews label May 15, 2025
@backportbot backportbot bot added this to the Nextcloud 30.0.11 milestone May 15, 2025
@icewind1991 icewind1991 force-pushed the backport/51818/stable30 branch from ddcac04 to 269b56c Compare May 15, 2025 11:52
@icewind1991 icewind1991 force-pushed the backport/51818/stable30 branch from 269b56c to 0ea3a58 Compare May 16, 2025 19:38
->from('storages')
->where($query->expr()->eq('id', $query->createNamedParameter($id)));
$result = $query->executeQuery()->fetchOne();
return $result ? (int)$result : null;

Check notice

Code scanning / Psalm

RiskyTruthyFalsyComparison Note

Operand of type false|mixed contains type mixed, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.
public function execute(InputInterface $input, OutputInterface $output): int {
$storage = $input->getArgument('storage');
$storageId = $this->fileUtils->getNumericStorageId($storage);
if (!$storageId) {

Check notice

Code scanning / Psalm

RiskyTruthyFalsyComparison Note

Operand of type int|null contains type int, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants