Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented May 18, 2025

Summary

streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error.

Checklist

@susnux susnux added this to the Nextcloud 32 milestone May 18, 2025
@susnux susnux requested a review from SystemKeeper May 18, 2025 14:50
@susnux susnux added the bug label May 18, 2025
@susnux susnux requested a review from a team as a code owner May 18, 2025 14:50
@susnux susnux added 3. to review Waiting for reviews feature: versions labels May 18, 2025
@susnux susnux requested review from Altahrim, ArtificialOwl and yemkareems and removed request for a team May 18, 2025 14:50
@susnux susnux requested review from icewind1991 and removed request for ArtificialOwl May 18, 2025 14:51
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't judge if it's the correct way, but fixes the tests I was having issues with.

@susnux susnux merged commit 0e20d9e into master May 18, 2025
209 of 217 checks passed
@susnux susnux deleted the fix/s3-versions branch May 18, 2025 17:53
@solracsf
Copy link
Member

Worth backport it?

@susnux
Copy link
Contributor Author

susnux commented May 18, 2025

Worth backport it?

No only an issue on master. Caused by #52890

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants