Skip to content

Add new share type federated_group and provider for VO app #52992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smesterheide wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add new share type federated_group and provider for VO app #52992

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfac1be
Add new share type federated_group and provider for VO app
smesterheide Feb 17, 2023
d4a1525
fix: address versioning and localization issues
smesterheide Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: address versioning and localization issues 
Signed-off-by: Sandro Mesterheide <[email protected]>
  • Loading branch information
@smesterheide
smesterheide committed Aug 11, 2025
commit d4a1525e6abfecb19714d9e50b0a5b9b1c2ca428
2 changes: 1 addition & 1 deletion apps/files_sharing/composer/composer/autoload_classmap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
'OCA\\Files_Sharing\\Migration\\Version22000Date20210216084241' => $baseDir . '/../lib/Migration/Version22000Date20210216084241.php',
'OCA\\Files_Sharing\\Migration\\Version24000Date20220208195521' => $baseDir . '/../lib/Migration/Version24000Date20220208195521.php',
'OCA\\Files_Sharing\\Migration\\Version24000Date20220404142216' => $baseDir . '/../lib/Migration/Version24000Date20220404142216.php',
'OCA\\Files_Sharing\\Migration\\Version26000Date20230117143027' => $baseDir . '/../lib/Migration/Version26000Date20230117143027.php',
'OCA\\Files_Sharing\\Migration\\Version26000Date20230117143027' => $baseDir . '/../lib/Migration/Version32000Date20230117143027.php',
'OCA\\Files_Sharing\\Migration\\Version31000Date20240821142813' => $baseDir . '/../lib/Migration/Version31000Date20240821142813.php',
'OCA\\Files_Sharing\\MountProvider' => $baseDir . '/../lib/MountProvider.php',
'OCA\\Files_Sharing\\Notification\\Listener' => $baseDir . '/../lib/Notification/Listener.php',
Expand Down
2 changes: 1 addition & 1 deletion apps/files_sharing/composer/composer/autoload_static.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class ComposerStaticInitFiles_Sharing
'OCA\\Files_Sharing\\Migration\\Version22000Date20210216084241' => __DIR__ . '/..' . '/../lib/Migration/Version22000Date20210216084241.php',
'OCA\\Files_Sharing\\Migration\\Version24000Date20220208195521' => __DIR__ . '/..' . '/../lib/Migration/Version24000Date20220208195521.php',
'OCA\\Files_Sharing\\Migration\\Version24000Date20220404142216' => __DIR__ . '/..' . '/../lib/Migration/Version24000Date20220404142216.php',
'OCA\\Files_Sharing\\Migration\\Version26000Date20230117143027' => __DIR__ . '/..' . '/../lib/Migration/Version26000Date20230117143027.php',
'OCA\\Files_Sharing\\Migration\\Version26000Date20230117143027' => __DIR__ . '/..' . '/../lib/Migration/Version32000Date20230117143027.php',
'OCA\\Files_Sharing\\Migration\\Version31000Date20240821142813' => __DIR__ . '/..' . '/../lib/Migration/Version31000Date20240821142813.php',
'OCA\\Files_Sharing\\MountProvider' => __DIR__ . '/..' . '/../lib/MountProvider.php',
'OCA\\Files_Sharing\\Notification\\Listener' => __DIR__ . '/..' . '/../lib/Notification/Listener.php',
Expand Down
2 changes: 1 addition & 1 deletion ...ration/Version26000Date20230117143027.php → ...ration/Version32000Date20230117143027.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
/**
* Auto-generated migration step: Please modify to your needs!
*/
class Version26000Date20230117143027 extends SimpleMigrationStep {
class Version32000Date20230117143027 extends SimpleMigrationStep {
/**
* @param IOutput $output
* @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
Expand Down
2 changes: 1 addition & 1 deletion lib/public/Federation/Exceptions/ProviderDoesNotExistsException.php
View file
Open in desktop
Copy link
Member

@provokateurin provokateurin Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change, not allowed

Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class ProviderDoesNotExistsException extends HintException {
* @param string|null $shareId cloud federation shareId
*/
public function __construct($resourceId, $shareId) {
$l = \OC::$server->getL10N('federation');
$l = \OCP\Util::getL10N('federation');
$message = 'Cloud Federation Provider with resourceId: "' . $resourceId . '" and shareId: "' . $shareId . '" does not exist.';
$hint = $l->t('Cloud Federation Provider with resourceId: "%s" and shareId: "%s" does not exist.', [$resourceId, $shareId]);
parent::__construct($message, $hint);
Expand Down
2 changes: 1 addition & 1 deletion lib/public/Share/IShare.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ interface IShare {

/**
* Extension to remote group share
* @since 30.0.0
* @since 32.0.0
Copy link
Member

@provokateurin provokateurin Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @since 32.0.0
* @since 33.0.0

*/
public const TYPE_FEDERATED_GROUP = 14;
Copy link
Contributor

@susnux susnux Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is for an external app then the name of the type should reflect this - if this is a general type such as per OCM and there are multiple apps that potentially implement this then its fine I guess


Expand Down