feat(IUser): add getQuotaBytes method to get machine readable quota
#53045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proper replacement for deprecated `OC_Util::getUserQuota`. Also we still use this in some cases we can now replace, moreover it just makes sense to have a machine readable format in the API instead of only the human readable format which is less precise. Alings also with `getQuota` of the quota storage, which already returned the machine readable format. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
enhancement
3. to review
susnux
requested review from
ArtificialOwl,
come-nc,
icewind1991,
provokateurin,
skjnldsv and
yemkareems
and removed request for
a team and
ArtificialOwl
come-nc
approved these changes
May 22, 2025
Comment on lines
+872
to
+873
| $this->assertEquals('1 GB', $user->getQuota()); | ||
| $this->assertEquals(1024 * 1024 * 1024, $user->getQuotaBytes()); |
Contributor
There was a problem hiding this comment.
But that’s 1 GiB, not 1 GB 🙀
Member
There was a problem hiding this comment.
I really dislike that we have this 🙈
provokateurin
approved these changes
May 22, 2025
8 tasks
Merged
joshtrichards
added a commit
that referenced
this pull request
Dec 1, 2025
Formally deprecated with 9.0.0 and we dropped final uses of it in #53045. Signed-off-by: Josh <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proper replacement for deprecated
OC_Util::getUserQuota. Also we still use this in some cases we can now replace, moreover it just makes sense to have a machine readable format in the API instead of only the human readable format which is less precise. Aligns also withgetQuotaof the quota storage, which already returned the machine readable format.Checklist