-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(files_sharing): show note, label and list of uploaded files on file drop #53055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to master |
5235cfc to
5a6d0df
Compare
|
Wow! Thank you for fixing that so quickly @susnux 😃 |
|
I was just here to enquire about the lack of uploaded file feeback and that the message function wasn't working. Thank for your contribution :) |
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works. Also looks good from the screenshots but did not review the code.
Thanks for fixing this! :)
@susnux is there a reason why you did not target master directly? |
No, I tried reproducing and fixing this for a ticket on 31 and only later noticed its bigger than expected so directly pushing it to 31 is easier and afterwards adjust for master. |
f226ad3 to
971c083
Compare
|
/compile |
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, but did not test
97fae34 to
c0060f8
Compare
…le drop This was missing from the Vue migration of the public share view: - Show the note as the description of the file drop - Show the label as the heading of the file drop if available - Show list of uploaded files for verification Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
c0060f8 to
c3e9c89
Compare
Summary
This was missing from the Vue migration of the public share view:
Checklist