Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented May 22, 2025

Summary

This was missing from the Vue migration of the public share view:

  • Show the note as the description of the file drop
  • Show the label as the heading of the file drop if available
  • Show list of uploaded files for verification

Screenshot 2025-05-22 at 17-01-20 File drop - Nextcloud

Checklist

@susnux susnux added this to the Nextcloud 31.0.6 milestone May 22, 2025
@susnux susnux requested review from a team, nfebe, skjnldsv and szaimen and removed request for a team May 22, 2025 15:06
@susnux
Copy link
Contributor Author

susnux commented May 22, 2025

/backport to master

@susnux susnux requested a review from artonge May 22, 2025 15:07
@susnux susnux force-pushed the fix/upload-file-drop-info branch from 5235cfc to 5a6d0df Compare May 22, 2025 15:09
@kousu
Copy link

kousu commented May 25, 2025

Wow! Thank you for fixing that so quickly @susnux 😃

@susnux susnux requested a review from skjnldsv May 25, 2025 18:54
@Lewis8265
Copy link

I was just here to enquire about the lack of uploaded file feeback and that the message function wasn't working. Thank for your contribution :)

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Also looks good from the screenshots but did not review the code.

Thanks for fixing this! :)

@szaimen
Copy link
Contributor

szaimen commented May 26, 2025

/backport to master

@susnux is there a reason why you did not target master directly?

@susnux
Copy link
Contributor Author

susnux commented May 26, 2025

is there a reason why you did not target master directly?

No, I tried reproducing and fixing this for a ticket on 31 and only later noticed its bigger than expected so directly pushing it to 31 is easier and afterwards adjust for master.

@susnux susnux force-pushed the fix/upload-file-drop-info branch from f226ad3 to 971c083 Compare May 26, 2025 09:38
@susnux
Copy link
Contributor Author

susnux commented May 26, 2025

/compile

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but did not test

@susnux susnux force-pushed the fix/upload-file-drop-info branch 2 times, most recently from 97fae34 to c0060f8 Compare May 26, 2025 10:42
@AndyScherzinger AndyScherzinger enabled auto-merge May 26, 2025 10:54
susnux and others added 2 commits May 26, 2025 14:14
…le drop

This was missing from the Vue migration of the public share view:
- Show the note as the description of the file drop
- Show the label as the heading of the file drop if available
- Show list of uploaded files for verification

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux force-pushed the fix/upload-file-drop-info branch from c0060f8 to c3e9c89 Compare May 26, 2025 12:14
@AndyScherzinger AndyScherzinger merged commit 30018bf into stable31 May 26, 2025
199 of 212 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/upload-file-drop-info branch May 26, 2025 12:54
@nextcloud-bot nextcloud-bot mentioned this pull request Jun 4, 2025
10 tasks
@susnux susnux mentioned this pull request Jun 6, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants