-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(declarativeSettings): support encryption of sensitive values #53121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some suggestions for improvements.
apps/settings/src/components/DeclarativeSettings/DeclarativeSection.vue
Outdated
Show resolved
Hide resolved
a2912d4 to
cd742aa
Compare
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except from the sprintf
cd742aa to
e570179
Compare
oleksandr-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall it looks good
e570179 to
ca17680
Compare
Signed-off-by: Andrey Borysenko <[email protected]>
7573fe6 to
7994332
Compare
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Summary
This PR introduces new Declarative setting field attribute
sensitive: true/false, available forTextandPasswordfield types. Sensitive fields are encrypted on server side and the values are not exposed to the UI.Declarative forms with handler (https://github.com/nextcloud/server/blob/master/lib/public/Settings/IDeclarativeSettingsFormWithHandlers.php) must implement this in their
setValue,getValuemethods, as well as external storage type (using events to handle getValue/setValue actions).For ExApps AppAPI handles this automatically inside its event handlers.
TODO
Checklist