Skip to content

perf(base): Stop setting up the FS for every basic auth request #53141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 7 commits into from
Jul 11, 2025
Merged

perf(base): Stop setting up the FS for every basic auth request #53141

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
689a853
fix(dav): Initialize the FS for the user right after authenticating
provokateurin May 27, 2025
0eae0e3
perf(base): Stop setting up the FS for every basic auth request
provokateurin May 27, 2025
24f7a2e
fix(core): Stop abusing the cache for avatar upload
provokateurin Jul 1, 2025
57191d4
refactor(Server): Deprecate \OCP\ICache service and replace it with a…
provokateurin Jun 2, 2025
0d8f983
chore: Remove unused \OC\Cache\File
provokateurin May 27, 2025
9070552
chore: Remove unused \OC\Cache\CappedMemoryCache
provokateurin May 27, 2025
caddc8d
chore(assets): Recompile assets
nextcloud-command Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
perf(base): Stop setting up the FS for every basic auth request 
Signed-off-by: provokateurin <[email protected]>
  • Loading branch information
@provokateurin
provokateurin committed Jul 8, 2025
commit 0eae0e3c069dcd26ffec93191baa7fe51a96768f
17 changes: 0 additions & 17 deletions lib/base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,23 +882,6 @@ public static function registerCleanupHooks(\OC\SystemConfig $systemConfig): voi
$throttler = Server::get(IThrottler::class);
$throttler->resetDelay($request->getRemoteAddress(), 'login', ['user' => $uid]);
}

try {
$cache = new \OC\Cache\File();
$cache->gc();
} catch (\OC\ServerNotAvailableException $e) {
// not a GC exception, pass it on
throw $e;
} catch (\OC\ForbiddenException $e) {
// filesystem blocked for this request, ignore
} catch (\Exception $e) {
// a GC exception should not prevent users from using OC,
// so log the exception
Server::get(LoggerInterface::class)->warning('Exception when running cache gc.', [
'app' => 'core',
'exception' => $e,
]);
}
});
}
}
Expand Down