Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Jun 3, 2025

Summary

Create an example event when a user logs in for the first time. The feature can be toggled and the event can be customized by admins.

I also harmonized the design of both settings sections (default contact and event) according to feedback from our designers.

With default data

Bildschirmfoto vom 2025-06-08 11-57-18

With custom event and contact

Bildschirmfoto vom 2025-06-08 11-57-42

Checklist

@st3iny st3iny self-assigned this Jun 3, 2025
@st3iny st3iny added enhancement 2. developing Work in progress feature: caldav Related to CalDAV internals labels Jun 3, 2025
@st3iny st3iny added this to the Nextcloud 32 milestone Jun 3, 2025
@st3iny
Copy link
Member Author

st3iny commented Jun 5, 2025

Design feedback

  • Example Content --> Example content (no capital c)
  • Subline in --main-text "Example content serves to showcase the features of Nextcloud. Default content is shipped with Nextcloud, and can be replaced by custom content"
  • For contacts: "Add example contact to user's address book when they first log in"
  • For calendar: "Add example event to user's calendar when they first log in"
  • Below each, there is an ⬆️ Upload secondary button and a ↺ Reset to default tertiary button
  • Add download buttons:
    • 👤 default_contact.vcf ⬇️ (styled like a list item) ⬆️ Upload (secondary)
    • 👤 custom_contact123asdf.vcf ⬇️ (styled like a list item) ⬆️ Upload (secondary) ↺ Reset to default (tertiary)
    • Width of the file should be fixed (e.g. 200px)

@st3iny st3iny added 3. to review Waiting for reviews feature: carddav Related to CardDAV internals and removed 2. developing Work in progress labels Jun 5, 2025
@st3iny st3iny marked this pull request as ready for review June 5, 2025 09:24
@st3iny st3iny requested review from a team as code owners June 5, 2025 09:24
@st3iny st3iny requested review from a team, ArtificialOwl, ChristophWurst, SebastianKrupinski, artonge, hamza221, nfebe and susnux and removed request for a team June 5, 2025 09:24
Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and code looks clean 🚀

@nimishavijay
Copy link
Member

nimishavijay commented Jun 5, 2025

Looks really nice now! :)
Only 3 minor changes for the file:

  • Remove the underline
  • make the text regular
  • Add like 4px space between the text and the download icon

Other than that it looks great :)

@st3iny
Copy link
Member Author

st3iny commented Jun 6, 2025

  • Both example content features should be enabled by default

@st3iny st3iny force-pushed the feat/example-event branch from 915cb04 to 4e2eea2 Compare June 16, 2025 09:53
@st3iny st3iny force-pushed the feat/example-event branch from 4e2eea2 to 7e7e5f5 Compare June 16, 2025 10:01
@st3iny st3iny merged commit 0450ce9 into master Jun 16, 2025
208 of 213 checks passed
@st3iny st3iny deleted the feat/example-event branch June 16, 2025 13:50
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement feature: caldav Related to CalDAV internals feature: carddav Related to CardDAV internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create example events

6 participants