Skip to content

[stable31] fix(core): correctly show displayname when picking a file #53347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 2 commits into from
Jun 12, 2025
Merged

[stable31] fix(core): correctly show displayname when picking a file #53347

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad44591
fix(core): correctly show displayname when picking a file
susnux Jun 3, 2025
9a624c3
chore(assets): Recompile assets
nextcloud-command Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(core): correctly show displayname when picking a file 
Ensure that the display name is shown instead of the filename (important for public shares).
Fixed in the library but the legacy wrapper still uses it.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @AndyScherzinger
susnux authored and AndyScherzinger committed Jun 12, 2025
commit ad445917a63612ee76d7f813f05689ef3ee3a882
6 changes: 3 additions & 3 deletions core/src/OC/dialogs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,13 +278,13 @@ const Dialogs = {
} else {
builder.setButtonFactory((nodes, path) => {
const buttons = []
const node = nodes?.[0]?.attributes?.displayName || nodes?.[0]?.basename
const target = node || basename(path)
const [node] = nodes
const target = node?.displayname || node?.basename || basename(path)

if (type === FilePickerType.Choose) {
buttons.push({
callback: legacyCallback(callback, FilePickerType.Choose),
label: node && !this.multiSelect ? t('core', 'Choose {file}', { file: node }) : t('core', 'Choose'),
label: node && !this.multiSelect ? t('core', 'Choose {file}', { file: target }) : t('core', 'Choose'),
type: 'primary',
})
}
Expand Down