Skip to content

fix: hide guests group when searching for principals #53369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 2 commits into from
Jun 17, 2025
Merged

fix: hide guests group when searching for principals #53369

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b66f35
fix: hide guests group when searching for principals
kesselb Jun 6, 2025
6254354
test(dav): add integration test for principal property search
kesselb Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: hide guests group when searching for principals 
Follow-up for #52914

Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb
kesselb committed Jun 17, 2025
commit 8b66f3518e0034bf31803b468ea49549bf843c8a
4 changes: 4 additions & 0 deletions apps/dav/lib/DAV/GroupPrincipalBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ public function searchPrincipals($prefixPath, array $searchProperties, $test = '
$groups = $this->groupManager->search($value, $searchLimit);

$results[] = array_reduce($groups, function (array $carry, IGroup $group) use ($restrictGroups) {
if ($group->hideFromCollaboration()) {
return $carry;
}

$gid = $group->getGID();
// is sharing restricted to groups only?
if ($restrictGroups !== false) {
Expand Down