Skip to content

Check if an app provide two-factor-auth providers before we try to use them #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jul 23, 2016
Merged

Check if an app provide two-factor-auth providers before we try to use them #534

nickvergessen merged 1 commit into from
Jul 23, 2016

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jul 23, 2016

Prevents log spam

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 23, 2016
@icewind1991 icewind1991 added this to the Nextcloud 11.0 milestone Jul 23, 2016
@mention-bot
Copy link

mention-bot commented Jul 23, 2016

@icewind1991, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst and @nickvergessen to be potential reviewers

@ChristophWurst
Copy link
Member

ChristophWurst commented Jul 23, 2016

👍 makes sense. I think the error only occurs if $this->appManager->getEnabledAppsForUser($user) returns app IDs of apps that do not exist any more on the file system and therefore the info.xml file can not be loaded.

@nickvergessen
Copy link
Member

nickvergessen commented Jul 23, 2016

https://github.com/nextcloud/server/pull/534/files?w=1

🙈 👍

@nickvergessen nickvergessen merged commit dddd43f into master Jul 23, 2016
@nickvergessen nickvergessen deleted the twofactor-isset branch July 23, 2016 13:49
@nickvergessen
Copy link
Member

nickvergessen commented Jul 23, 2016

Backport to stable10?

@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 5, 2016

cc @icewind1991 @ChristophWurst @karlitschek

@karlitschek
Copy link
Member

karlitschek commented Aug 6, 2016

great. please backport 👍

@icewind1991 icewind1991 mentioned this pull request Aug 6, 2016
Merged
@icewind1991
Copy link
Member Author

icewind1991 commented Aug 6, 2016

Stable 10: #756

@ChristophWurst ChristophWurst mentioned this pull request Aug 9, 2016
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 16, 2021
Open
R0Wi pushed a commit to R0Wi/server that referenced this pull request Nov 22, 2025
@oleksandr-nc
Merge pull request nextcloud#534 from nextcloud/chore/deprec-removal/…
32f13ee 
…occ-deploy

(chore): removed deprecated occ app_api:deploy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 11.0

Development

Successfully merging this pull request may close these issues.

7 participants

@icewind1991 @mention-bot @ChristophWurst @nickvergessen @MorrisJobke @karlitschek