fix(tests): Fix 32bits PHPUnit tests #53417
Conversation
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
Altahrim,
ArtificialOwl and
leftybournes
and removed request for
a team
Also add output when enabling applications, and watch phpunit configuration file for changes. Signed-off-by: Côme Chilliet <[email protected]>
Simply let the Exception bubble up instead of caching it and using grep to then detect it. Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/fix-32bits-phpunit
branch
from
998afb4 to
b1f6283
Compare
come-nc
added
3. to review
| with: | ||
| php-version: ${{ matrix.php-versions }} | ||
| extensions: ctype, curl, dom, fileinfo, gd, imagick, intl, json, mbstring, openssl, pdo_sqlite, posix, sqlite, xml, zip, apcu | ||
| extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite, apcu, ldap |
There was a problem hiding this comment.
apcu, bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, ldap, libxml, mbstring, openssl, pcntl, pdo_sqlite, posix, redis, session, simplexml, sqlite, xmlreader, xmlwriter, zip, zlib
I would love to have the list sorted 🙈
There was a problem hiding this comment.
Yeah but I reused the order of the other jobs to have it easier to compare.
It’s a mystery to me why no other job have the ldap module though, is php-32bit the only CI running user_ldap tests?
There was a problem hiding this comment.
The ldap module could be enabled by default though.
There was a problem hiding this comment.
Unfortunately phpunit warnings and skipped tests are not printed
Update: but rather integration tests and they run and ldap is enabled, e.g.: https://github.com/nextcloud/server/actions/runs/15561112793
Summary
Follow-up of #48210 which broke 32bit testing in CI
Checklist