Skip to content

Fix TimedJob execution time to allow job execution exactly when scheduled #53418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 3 commits into from
Jul 3, 2025
Merged

Fix TimedJob execution time to allow job execution exactly when scheduled #53418

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e418323
fix: adjust setTimeout value for ClearOldStatusesBackgroundJob
salmart-dev Jun 6, 2025
125696b
fix: delete UserStatusAutomation when user is deleted
salmart-dev Jun 30, 2025
289b7ab
test: check that UserStatusAutomation is cleaned up
salmart-dev Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: delete UserStatusAutomation when user is deleted 
Signed-off-by: Salvatore Martire <[email protected]>
  • Loading branch information
@salmart-dev
salmart-dev committed Jul 1, 2025
commit 125696bfbcd0364fd66d48a35508545426138fd0
5 changes: 5 additions & 0 deletions apps/dav/lib/Listener/UserEventsListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,14 @@

namespace OCA\DAV\Listener;

use OCA\DAV\BackgroundJob\UserStatusAutomation;
use OCA\DAV\CalDAV\CalDavBackend;
use OCA\DAV\CardDAV\CardDavBackend;
use OCA\DAV\CardDAV\SyncService;
use OCA\DAV\Service\ExampleContactService;
use OCA\DAV\Service\ExampleEventService;
use OCP\Accounts\UserUpdatedEvent;
use OCP\BackgroundJob\IJobList;
use OCP\Defaults;
use OCP\EventDispatcher\Event;
use OCP\EventDispatcher\IEventListener;
Expand Down Expand Up @@ -49,6 +51,7 @@ public function __construct(
private ExampleContactService $exampleContactService,
private ExampleEventService $exampleEventService,
private LoggerInterface $logger,
private IJobList $jobList,
) {
}

Expand Down Expand Up @@ -124,6 +127,8 @@ public function postDeleteUser(string $uid): void {
$this->cardDav->deleteAddressBook($addressBook['id']);
}

$this->jobList->remove(UserStatusAutomation::class, ['userId' => $uid]);

unset($this->calendarsToDelete[$uid]);
unset($this->subscriptionsToDelete[$uid]);
unset($this->addressBooksToDelete[$uid]);
Expand Down