refactor(files): move hotkey handling to composable #53437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
skjnldsv
approved these changes
Jun 16, 2025
artonge
approved these changes
Jun 17, 2025
Member
|
Conflicts 😢 |
skjnldsv
added
2. developing
susnux
force-pushed
the
refactor/files-hotkeys
branch
from
0a8dbb4 to
4b4e25b
Compare
susnux
added
3. to review
This is a composable - not a service, because it is using the `useHotKey` composable. At this moment it works, but in general its only safe to put composables into `setup`-context. This makes it future prove. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
refactor/files-hotkeys
branch
from
4b4e25b to
3a5769e
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a composable - not a service, because it is using the
useHotKeycomposable. At this moment it works, but in general its only safe to put composables intosetup-context.So while it at the moment with the current implementation (library) works, it is prone to break as soon as some lifecycle hooks might be called. So lets make it future-proof.
Checklist