fix(router): In debug mode, cache routes only for 3 seconds #53453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows testing a newly added or changed route in your application without having to wait 1 hour or bump the application version. Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
Altahrim,
icewind1991 and
skjnldsv
and removed request for
a team
kesselb
approved these changes
Jun 12, 2025
skjnldsv
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows testing a newly added or changed route in your application without having to wait 1 hour or bump the application version.
I thought about disabling the
CachingRouterin debug mode instead, but that would mean none of us devs would run its code on our test instance and would increase the risk of missing issues in there.Checklist