fix(OCM-invites): Use the correct way of getting the email

[mickenordin]

It seems primary email can sometimes be empty, even if the user has an email set.

This patch should fix that so that we always have an email if it exists.

[blizzz]

I think this PRs introduces the failing tests:

[provokateurin]

Yeah the CI of this PR was red when @AndyScherzinger merged it :/

[mickenordin]

It is not clear to me what should be the correct way of getting the mail address. getPrimaryEMail sounds so correct, but the code comments seem to indicate that getEMailAddress is the one to be used in reality, and when the code was used at SURF the primary email was empty even when an email was set (which was not the case when I tested it).

So either we need to do some more if-then-clauses to try to get the primary email and fallback to getEMAil if that fails, or it is just the case that the test now fails for some reason, but the code is correct, and we need to fix the test.

[nickvergessen]

• For now, it just needs a similar adjust on the tests to pass again: test: Adjust tests to match code again #53502

But in general I'm not sure about the code change.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)