Skip to content

fix: don't create an empty file before writing the contents in OC_Util::copyr #53461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icewind1991 merged 1 commit into from
Jun 25, 2025
Merged

fix: don't create an empty file before writing the contents in OC_Util::copyr #53461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: don't create an empty file before writing the contents in OC_Uti… 
…l::copyr

Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991
icewind1991 committed Jun 24, 2025
commit 1d2b991bda4d74499c55783bc98b317b2e589ba4
3 changes: 1 addition & 2 deletions lib/private/legacy/OC_Util.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,13 @@ public static function copyr($source, \OCP\Files\Folder $target) {
$child = $target->newFolder($file);
self::copyr($source . '/' . $file, $child);
} else {
$child = $target->newFile($file);
$sourceStream = fopen($source . '/' . $file, 'r');
if ($sourceStream === false) {
$logger->error(sprintf('Could not fopen "%s"', $source . '/' . $file), ['app' => 'core']);
closedir($dir);
return;
}
$child->putContent($sourceStream);
$target->newFile($file, $sourceStream);
}
}
}
Expand Down
Loading