fix(files_sharing): Hide link shares for users in excluded groups #53466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
feature/hide-external-shares-excluded-groups
branch
2 times, most recently
from
137152b to
1e8112c
Compare
Contributor
Author
|
Should this apply to emails as well? |
nfebe
requested review from
artonge,
marcoambrosini,
skjnldsv,
sorbaugh and
susnux
and removed request for
a team,
artonge and
skjnldsv
nfebe
force-pushed
the
feature/hide-external-shares-excluded-groups
branch
2 times, most recently
from
cccdaf9 to
37b7486
Compare
AndyScherzinger
approved these changes
Jun 17, 2025
AndyScherzinger
added
design
nfebe
force-pushed
the
feature/hide-external-shares-excluded-groups
branch
from
b4e9c0e to
23e44f1
Compare
jancborchardt
approved these changes
Jun 17, 2025
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
@nfebe since the setting is called "Allow users to share via link and emails", exclusion should apply to both link and email. :)
marcoambrosini
approved these changes
Jun 17, 2025
nfebe
force-pushed
the
feature/hide-external-shares-excluded-groups
branch
from
23e44f1 to
595df96
Compare
nfebe
commented
Jun 17, 2025
Contributor
Author
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Prevents both emails and link shares now.
| }, | ||
| externalShareInputPlaceholder() { | ||
| if (!this.isLinkSharingAllowed) { |
Contributor
Author
There was a problem hiding this comment.
This was already handled in the SharingInput and now the text updated to match so all good now.
- Added frontend check to hide link shares if, public sharing is disabled. Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
feature/hide-external-shares-excluded-groups
branch
from
595df96 to
57f3edc
Compare
Contributor
Author
|
/compile |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
nfebe
changed the title
nfebe
force-pushed
the
feature/hide-external-shares-excluded-groups
branch
3 times, most recently
from
7a9a58e to
edb7fec
Compare
Signed-off-by: nextcloud-command <[email protected]>
nfebe
force-pushed
the
feature/hide-external-shares-excluded-groups
branch
from
edb7fec to
9583a67
Compare
This was referenced Jun 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluded groups should not see the create link share option in UI?