fix: do not extract fields for blank template #53477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
requested review from
artonge and
sorbaugh
and removed request for
a team
elzody
added
3. to review
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
11 tasks
elzody
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Office team
juliusknorr
approved these changes
Jun 17, 2025
skjnldsv
approved these changes
Jun 17, 2025
Member
|
/compile rebase |
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/unnecessary-template-fields-request
branch
from
e8d508e to
77da39c
Compare
Contributor
Author
|
/backport to stable31 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a request to the
/ocs/v2.php/apps/files/api/v1/templates/fields/{fileid}endpoint where the file ID isundefined. This was due to the template field extraction request being submitted on the blank template and invalid template selections as well. In this case, we skip the request and use an empty array of fields.In the end, it saves a few miliseconds of time in these cases.
Checklist