fix(sharing): fix json decoding the list of groups excluded from sharing #53503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json_decode() returns stdclass by default instead of an associative object, which can't be used for array_diff or array_intersect later Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
added
bug
3. to review
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
come-nc
approved these changes
Jun 16, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
The code block with the fallback to comma-separated list is weird, we should have a migration if needed and only store as JSON.
But that’s not changed by this PR.
tcitworld
requested review from
a team and
yemkareems
and removed request for
a team
Merged
AndyScherzinger
deleted the
fix-json-decoding-groups-excluded-from-share
branch
This was referenced Aug 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_decode()returns stdclass by default instead of an associative object, which can't be used forarray_difforarray_intersectlaterThis can prevent login as it's used when mounting user storages.
Summary
Details
{ "Exception": "Exception", "Message": "array_intersect(): Argument #2 must be of type array, stdClass given in file '/var/www/nc/nextcloud-30.0.10/lib/private/Share20/ShareDisableChecker.php' line 69", "Code": 0, "Trace": [ { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/AppFramework/App.php", "line": 161, "function": "dispatch", "class": "OC\\\\AppFramework\\\\Http\\\\Dispatcher", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Route/Router.php", "line": 303, "function": "main", "class": "OC\\\\AppFramework\\\\App", "type": "::" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/base.php", "line": 1010, "function": "match", "class": "OC\\\\Route\\\\Router", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/index.php", "line": 24, "function": "handleRequest", "class": "OC", "type": "::" } ], "File": "/var/www/nc/nextcloud-30.0.10/lib/private/AppFramework/Http/Dispatcher.php", "Line": 146, "Previous": { "Exception": "TypeError", "Message": "array_intersect(): Argument #2 must be of type array, stdClass given", "Code": 0, "Trace": [ { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Share20/ShareDisableChecker.php", "line": 69, "function": "array_intersect" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Files/SetupManager.php", "line": 119, "function": "sharingDisabledForUser", "class": "OC\\\\Share20\\\\ShareDisableChecker", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Files/SetupManager.php", "line": 327, "function": "setupBuiltinWrappers", "class": "OC\\\\Files\\\\SetupManager", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Files/SetupManager.php", "line": 222, "function": "setupRoot", "class": "OC\\\\Files\\\\SetupManager", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Files/SetupManager.php", "line": 303, "function": "oneTimeUserSetup", "class": "OC\\\\Files\\\\SetupManager", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Files/SetupManager.php", "line": 202, "function": "setupForUserWith", "class": "OC\\\\Files\\\\SetupManager", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Files/Filesystem.php", "line": 332, "function": "setupForUser", "class": "OC\\\\Files\\\\SetupManager", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Cache/File.php", "line": 34, "function": "initMountPoints", "class": "OC\\\\Files\\\\Filesystem", "type": "::" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Cache/File.php", "line": 155, "function": "getStorage", "class": "OC\\\\Cache\\\\File", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/base.php", "line": 845, "function": "gc", "class": "OC\\\\Cache\\\\File", "type": "->" }, { "function": "{closure}", "class": "OC", "type": "::", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Hooks/EmitterTrait.php", "line": 88, "function": "call_user_func_array" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Hooks/PublicEmitter.php", "line": 22, "function": "emit", "class": "OC\\\\Hooks\\\\BasicEmitter", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/User/Session.php", "line": 349, "function": "emit", "class": "OC\\\\Hooks\\\\PublicEmitter", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/CompleteLoginCommand.php", "line": 22, "function": "completeLogin", "class": "OC\\\\User\\\\Session", "type": "->", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/ALoginCommand.php", "line": 22, "function": "process", "class": "OC\\\\Authentication\\\\Login\\\\CompleteLoginCommand", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/LoggedInCheckCommand.php", "line": 41, "function": "processNextOrFinishSuccessfully", "class": "OC\\\\Authentication\\\\Login\\\\ALoginCommand", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/ALoginCommand.php", "line": 22, "function": "process", "class": "OC\\\\Authentication\\\\Login\\\\LoggedInCheckCommand", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/EmailLoginCommand.php", "line": 51, "function": "processNextOrFinishSuccessfully", "class": "OC\\\\Authentication\\\\Login\\\\ALoginCommand", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/ALoginCommand.php", "line": 22, "function": "process", "class": "OC\\\\Authentication\\\\Login\\\\EmailLoginCommand", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/UidLoginCommand.php", "line": 36, "function": "processNextOrFinishSuccessfully", "class": "OC\\\\Authentication\\\\Login\\\\ALoginCommand", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/ALoginCommand.php", "line": 22, "function": "process", "class": "OC\\\\Authentication\\\\Login\\\\UidLoginCommand", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/UserDisabledCheckCommand.php", "line": 39, "function": "processNextOrFinishSuccessfully", "class": "OC\\\\Authentication\\\\Login\\\\ALoginCommand", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/ALoginCommand.php", "line": 22, "function": "process", "class": "OC\\\\Authentication\\\\Login\\\\UserDisabledCheckCommand", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/PreLoginHookCommand.php", "line": 34, "function": "processNextOrFinishSuccessfully", "class": "OC\\\\Authentication\\\\Login\\\\ALoginCommand", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Authentication/Login/Chain.php", "line": 45, "function": "process", "class": "OC\\\\Authentication\\\\Login\\\\PreLoginHookCommand", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/core/Controller/LoginController.php", "line": 326, "function": "process", "class": "OC\\\\Authentication\\\\Login\\\\Chain", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/AppFramework/Http/Dispatcher.php", "line": 208, "function": "tryLogin", "class": "OC\\\\Core\\\\Controller\\\\LoginController", "type": "->", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/AppFramework/Http/Dispatcher.php", "line": 114, "function": "executeController", "class": "OC\\\\AppFramework\\\\Http\\\\Dispatcher", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/AppFramework/App.php", "line": 161, "function": "dispatch", "class": "OC\\\\AppFramework\\\\Http\\\\Dispatcher", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/private/Route/Router.php", "line": 303, "function": "main", "class": "OC\\\\AppFramework\\\\App", "type": "::" }, { "file": "/var/www/nc/nextcloud-30.0.10/lib/base.php", "line": 1010, "function": "match", "class": "OC\\\\Route\\\\Router", "type": "->" }, { "file": "/var/www/nc/nextcloud-30.0.10/index.php", "line": 24, "function": "handleRequest", "class": "OC", "type": "::" } ], "File": "/var/www/nc/nextcloud-30.0.10/lib/private/Share20/ShareDisableChecker.php", "Line": 69 }, "message": "array_intersect(): Argument #2 must be of type array, stdClass given in file '/var/www/nc/nextcloud-30.0.10/lib/private/Share20/ShareDisableChecker.php' line 69", "exception": {}, "CustomMessage": "array_intersect(): Argument #2 must be of type array, stdClass g" }Checklist