fix: Correctly ignore lazy ghost initialization in debug warning about direct constructor call #53507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t direct constructor call Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
susnux
reviewed
Jun 16, 2025
| $step['class'] === \ReflectionClass::class && | ||
| $step['function'] === 'initializeLazyObject' && | ||
| $step['class'] === SimpleContainer::class && | ||
| preg_match('/{closure:OC\\\\AppFramework\\\\Utility\\\\SimpleContainer::buildClass\\(\\):\\d+}/', $step['function']) && |
Contributor
There was a problem hiding this comment.
Performance wise maybe str_starts_with until the end of buildClass?
Contributor
Author
There was a problem hiding this comment.
Performance in debug mode is not a concern 🤷
But yeah, that would work too, I do not really care which gets merged.
susnux
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It appears that ReflectionClass does not appear in the trace in the end, so we need to match the closure to be sure we’re fine.
I use preg_match so that it does not break when the line number of the closure changes.
Checklist