Skip to content

fix(encryption): Fix DI for encryption Manager class #53516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Jun 17, 2025
Merged

fix(encryption): Fix DI for encryption Manager class #53516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(encryption): Fix DI for encryption Manager class 
Only IManager was registered but the class name is used as well for DI
 in the encryption application. This was causing a crash of encryption
 command when using PHP 8.4 and lazy ghosts.

Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Jun 16, 2025
commit a9acaaa45f13868dc927072c5701173a2268c321
3 changes: 2 additions & 1 deletion lib/private/Server.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ public function __construct($webRoot, \OC\Config $config) {
return new Profiler($c->get(SystemConfig::class));
});

$this->registerService(\OCP\Encryption\IManager::class, function (Server $c): Encryption\Manager {
$this->registerService(Encryption\Manager::class, function (Server $c): Encryption\Manager {
$view = new View();
$util = new Encryption\Util(
$view,
Expand All @@ -339,6 +339,7 @@ public function __construct($webRoot, \OC\Config $config) {
new ArrayCache()
);
});
$this->registerAlias(\OCP\Encryption\IManager::class, Encryption\Manager::class);

$this->registerService(IFile::class, function (ContainerInterface $c) {
$util = new Encryption\Util(
Expand Down
Loading