Skip to content

Cleanup DependencyAnalyzer and InfoParser #53537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 3 commits into from
Jul 9, 2025
Merged

Cleanup DependencyAnalyzer and InfoParser #53537

provokateurin merged 3 commits into from
Jul 9, 2025

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Jun 17, 2025

Summary

  • Cleanup typing and psalm issues in DependencyAnalyzer and InfoParser
  • Fix parsing database dependency with attributes, like min-version
  • Move method from legacy OC_App to InfoParser where is makes sense

Checklist

@come-nc come-nc added this to the Nextcloud 32 milestone Jun 17, 2025
@come-nc come-nc self-assigned this Jun 17, 2025
@come-nc come-nc added the 2. developing Work in progress label Jun 17, 2025
@come-nc come-nc force-pushed the fix/cleanup-dependencyanalyser branch from 66c4784 to ec8986e Compare June 19, 2025 08:32
come-nc added 2 commits July 8, 2025 15:51
@come-nc
chore: Cleanup DependencyAnalyzer and InfoParser
fb4e580 
Also fix support for database dependency with attributes in the info.xml

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
chore: Move info parsing related method from OC_App to InfoParser
1f5e232 
Also fix the tests

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc force-pushed the fix/cleanup-dependencyanalyser branch from ec8986e to c37d5e2 Compare July 8, 2025 13:57
@come-nc
chore: update psalm baseline
adb6f00 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc force-pushed the fix/cleanup-dependencyanalyser branch from c37d5e2 to adb6f00 Compare July 9, 2025 08:15
@come-nc come-nc marked this pull request as ready for review July 9, 2025 09:44
@come-nc come-nc requested a review from a team as a code owner July 9, 2025 09:44
@come-nc come-nc requested review from nfebe, provokateurin and skjnldsv and removed request for a team July 9, 2025 09:44
@come-nc come-nc added 3. to review Waiting for reviews technical debt and removed 2. developing Work in progress labels Jul 9, 2025
@come-nc come-nc requested a review from susnux July 9, 2025 09:45
@provokateurin provokateurin merged commit 3da7481 into master Jul 9, 2025
220 of 228 checks passed
@provokateurin provokateurin deleted the fix/cleanup-dependencyanalyser branch July 9, 2025 11:16
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@provokateurin provokateurin provokateurin approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@susnux susnux Awaiting requested review from susnux

Assignees

@come-nc come-nc

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: [PHP] Error: Array to string conversion at /usr/share/nginx/nextcloud/lib/private/App/DependencyAnalyzer.php#398

4 participants

@come-nc @skjnldsv @provokateurin