Skip to content

fix(files_reminders): Join the reminders with the file system metadata #53548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
come-nc merged 1 commit into from
Jun 23, 2025
Merged

fix(files_reminders): Join the reminders with the file system metadata #53548

come-nc merged 1 commit into from
Jun 23, 2025

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Jun 17, 2025 •
edited by provokateurin
Loading

Eliminates the need to load fileIds into PHP by using a database INNER JOIN with the oc_filecache table, filtering files by their parent (the folder's ID) directly in the SQL query. This avoids the IN clause entirely

Checklist

@solracsf solracsf added the 2. developing Work in progress label Jun 17, 2025
@solracsf solracsf mentioned this pull request Jun 17, 2025
Closed
8 tasks
provokateurin
provokateurin approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks much better and should fix #53527

@provokateurin
Copy link
Member

provokateurin commented Jun 23, 2025

@solracsf any reason to keep it as a draft?

@solracsf

This comment was marked as resolved.

Sign in to view
@provokateurin provokateurin marked this pull request as ready for review June 23, 2025 07:48
@provokateurin provokateurin requested a review from a team as a code owner June 23, 2025 07:48
@provokateurin provokateurin requested review from Altahrim, ArtificialOwl and icewind1991 and removed request for a team June 23, 2025 07:48
@provokateurin
Copy link
Member

provokateurin commented Jun 23, 2025

/backport to stable31

@provokateurin

This comment was marked as resolved.

Sign in to view
@provokateurin provokateurin requested review from come-nc and susnux June 23, 2025 07:49
@come-nc come-nc merged commit f980d94 into master Jun 23, 2025
202 of 204 checks passed
@come-nc come-nc deleted the fixFilesRemindersJoins branch June 23, 2025 10:24
@backportbot

This comment was marked as outdated.

Sign in to view
@backportbot backportbot bot mentioned this pull request Jun 23, 2025
Merged
kesselb
kesselb reviewed Jun 23, 2025
View reviewed changes
@kesselb kesselb mentioned this pull request Jun 23, 2025
Merged
4 tasks
@provokateurin
Copy link
Member

provokateurin commented Jun 23, 2025

The stable30 backport must also include #53644!

@solracsf
Copy link
Member Author

solracsf commented Jun 23, 2025

The stable30 backport must also include #53644!

findAllInFolder() is v31+

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb left review comments

@provokateurin provokateurin provokateurin approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@susnux susnux Awaiting requested review from susnux

Assignees

No one assigned

Labels

2. developing Work in progress backport-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: More than 1000 expressions in a list are not allowed on Oracle. (postgresql, in files_reminders / cacheFolder)

5 participants

@solracsf @provokateurin @kesselb @come-nc