Skip to content

Feat/sync truncation2 #53551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kesselb wants to merge 8 commits into from
Closed

Feat/sync truncation2 #53551

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
72d3a68
feat(cardav): support result truncation for addressbook federation
hamza221 Jan 8, 2025
52ab616
fix(federation): address book truncation looping forever
st3iny May 13, 2025
9847261
fixup! feat(cardav): support result truncation for addressbook federa…
hamza221 Jun 10, 2025
9a3f28b
fixup! feat(cardav): support result truncation for addressbook federa…
hamza221 Jun 10, 2025
29fba71
fixup! feat(cardav): support result truncation for addressbook federa…
hamza221 Jun 10, 2025
b984072
feat(cardav): support result truncation for addressbook federation
hamza221 Jan 8, 2025
61d495b
fix(carddav): return correct sync token for non-truncated requests
kesselb Jun 17, 2025
2743b1d
feat(carddav): handle truncated non-initial requests
kesselb Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! feat(cardav): support result truncation for addressbook federa… 
…tion

Signed-off-by: Hamza <[email protected]>
  • Loading branch information
@hamza221 @kesselb
hamza221 authored and kesselb committed Jul 16, 2025
commit 29fba71af8579b0dba1b857d9c7e9730b2bb2401
8 changes: 4 additions & 4 deletions apps/dav/lib/CardDAV/CardDavBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,7 @@ public function getChangesForAddressBook($addressBookId, $syncToken, $syncLevel,
)
)->orderBy('synctoken');

if (is_int($limit) && $limit > 0) {
if ($limit > 0) {
$qb->setMaxResults($limit);
}

Expand Down Expand Up @@ -962,11 +962,11 @@ public function getChangesForAddressBook($addressBookId, $syncToken, $syncLevel,
$stmt = $qb->executeQuery();
$values = $stmt->fetchAll(\PDO::FETCH_ASSOC);
if (empty($values)) {
$result['added'] = [];
return $result;
$result['added'] = [];
return $result;
}
$lastID = $values[array_key_last($values)]['id'];
if (count($values) >= $limit){
if (count($values) >= $limit) {
$result['syncToken'] = 'init_' . $lastID . '_' . $currentToken;
$result['result_truncated'] = true;
}
Expand Down
Loading