Skip to content

[stable30] fix: hide guests group when searching for principals #53552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 3 commits into from
Jul 2, 2025
Merged

[stable30] fix: hide guests group when searching for principals #53552

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
543c4d7
fix: hide guests group from principal backend
kesselb May 16, 2025
e6b2661
fix: hide guests group when searching for principals
kesselb Jun 6, 2025
dbbacb4
test(dav): add integration test for principal property search
kesselb Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: hide guests group from principal backend 
Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb
kesselb committed Jul 2, 2025
commit 543c4d79624ca86d1b94eaaf139d4fa834a77858
8 changes: 5 additions & 3 deletions apps/dav/lib/DAV/GroupPrincipalBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,10 @@ public function getPrincipalsByPrefix($prefixPath) {
$principals = [];

if ($prefixPath === self::PRINCIPAL_PREFIX) {
foreach ($this->groupManager->search('') as $user) {
$principals[] = $this->groupToPrincipal($user);
foreach ($this->groupManager->search('') as $group) {
if (!$group->hideFromCollaboration()) {
$principals[] = $this->groupToPrincipal($group);
}
}
}

Expand All @@ -93,7 +95,7 @@ public function getPrincipalByPath($path) {
$name = urldecode($elements[2]);
$group = $this->groupManager->get($name);

if (!is_null($group)) {
if ($group !== null && !$group->hideFromCollaboration()) {
return $this->groupToPrincipal($group);
}

Expand Down