Skip to content

Conversation

@icewind1991
Copy link
Member

#53462 caused creating an empty¹ file on s3 to create a version, messing with the versioning tests.

This removes the empty¹ file step in the tests.

1: s3 doesn't actually support empty files, so we create a 1 byte file instead

@icewind1991 icewind1991 added this to the Nextcloud 32 milestone Jun 23, 2025
@icewind1991 icewind1991 requested a review from a team as a code owner June 23, 2025 17:09
@icewind1991 icewind1991 requested review from artonge, sorbaugh and yemkareems and removed request for a team June 23, 2025 17:09
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jun 23, 2025
@susnux susnux changed the title fix: create new file with content when creating test files for versioning tests test: create new file with content when creating test files for versioning tests Jun 23, 2025
@susnux susnux added the tests Related to tests label Jun 23, 2025
@provokateurin provokateurin merged commit 6bdde90 into master Jun 24, 2025
195 of 197 checks passed
@provokateurin provokateurin deleted the version-test-new-file branch June 24, 2025 07:14
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants