chore(Log): remove unused getEntries method #53682
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hasn't been used for many years (since #2214). All this functionality was moved to the LogReader app. Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
joshtrichards
requested review from
come-nc and
yemkareems
and removed request for
a team
joshtrichards
added
3. to review
Signed-off-by: Josh <[email protected]>
ChristophWurst
added
the
pending documentation
come-nc
reviewed
Jun 26, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
It should go through deprecation procedure, even if unused.
It’s not broken or causing any trouble, so there’s no hurry in removing it I think?
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This method hasn't been used since ~#2214. All this functionality was moved to the LogReader app. It was de facto deprecated nearly 10 years ago. There are zero references to it across all of GitHub. Technically a public API, but...
TODO
Checklist