Skip to content

fix(settings): translate pronounce account property #53698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Jun 27, 2025
Merged

fix(settings): translate pronounce account property #53698

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7473c23
fix(settings): translate pronounce account property
susnux Jun 26, 2025
89738e1
chore(assets): Recompile assets
nextcloud-command Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(settings): translate pronounce account property 
Template string is not working.
Additionally migrate to Typescript and directly import `t` method.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Jun 27, 2025
commit 7473c232c1af6421cd06269bbbea68e04988ef24
24 changes: 13 additions & 11 deletions apps/settings/src/components/PersonalInfo/PronounsSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,18 @@
:placeholder="randomPronounsPlaceholder" />
</template>

<script>
import { loadState } from '@nextcloud/initial-state'
<script lang="ts">
import type { IAccountProperty } from '../../constants/AccountPropertyConstants.ts'

import { loadState } from '@nextcloud/initial-state'
import { t } from '@nextcloud/l10n'
import { defineComponent } from 'vue'
import AccountPropertySection from './shared/AccountPropertySection.vue'
import { NAME_READABLE_ENUM } from '../../constants/AccountPropertyConstants.ts'

import { NAME_READABLE_ENUM } from '../../constants/AccountPropertyConstants.js'

const { pronouns } = loadState('settings', 'personalInfoParameters', {})
const { pronouns } = loadState<{ pronouns: IAccountProperty }>('settings', 'personalInfoParameters')

export default {
export default defineComponent({
name: 'PronounsSection',

components: {
Expand All @@ -33,13 +35,13 @@ export default {
computed: {
randomPronounsPlaceholder() {
const pronouns = [
this.t('settings', 'she/her'),
this.t('settings', 'he/him'),
this.t('settings', 'they/them'),
t('settings', 'she/her'),
t('settings', 'he/him'),
t('settings', 'they/them'),
]
const pronounsExample = pronouns[Math.floor(Math.random() * pronouns.length)]
return this.t('settings', `Your pronouns. E.g. ${pronounsExample}`, { pronounsExample })
return t('settings', 'Your pronouns. E.g. {pronounsExample}', { pronounsExample })
},
},
}
})
</script>
Loading