Skip to content

fix(DAV): Clean-up remote + handle application/xml properly #53703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix(DAV): Clean-up remote + handle application/xml properly #53703

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ac40a35
fix(DAV): Handle application/xml in remote properly
joshtrichards Jun 26, 2025
aa09853
chore: fixup remote.php
joshtrichards Aug 13, 2025
ccc7584
chore: re-organize remote.php
joshtrichards Aug 13, 2025
7dbe1df
chore: drop unused remote_ dynamic resolver
joshtrichards Aug 18, 2025
b930082
fix: fixup for lint
joshtrichards Aug 18, 2025
c1fbf19
chore: Update psalm-baseline.xml
joshtrichards Aug 18, 2025
5eff9e3
chore: unify public.php with updated remote.php
joshtrichards Aug 18, 2025
02affcb
chore: drop unused IConfig from remote.php
joshtrichards Aug 18, 2025
1238f6d
Merge branch 'master' into jtr-refactor-remote-php
joshtrichards Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fixup for lint 
Signed-off-by: Josh <[email protected]>
  • Loading branch information
@joshtrichards
joshtrichards authored Aug 18, 2025
commit b9300824263243ba01f83b0519a2be246de9f6f3
6 changes: 3 additions & 3 deletions remote.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function resolveService(string $service): string {
$parts = explode('/', $file, 2);
$app = $parts[0];
\OC::$REQUESTEDAPP = $app;

// Load all required applications
$appManager = Server::get(IAppManager::class);
$appManager->loadApps(['authentication']);
Expand All @@ -93,10 +93,10 @@ function resolveService(string $service): string {
if (!$appManager->isEnabledForUser($app)) {
throw new RemoteException('App not installed: ' . $app, 503); // or maybe 404?
}

// Load the app
$appManager->loadApp($app);

$baseuri = OC::$WEBROOT . '/remote.php/' . $service . '/';
require_once $file;
} catch (Exception $ex) {
Expand Down
Loading