Skip to content

Conversation

@Mark-PAS
Copy link
Contributor

Summary

Only attempt $result array access if array not empty.

TODO

  • ...

Checklist

@Mark-PAS Mark-PAS requested a review from a team as a code owner June 28, 2025 04:04
@Mark-PAS Mark-PAS requested review from come-nc, icewind1991 and leftybournes and removed request for a team June 28, 2025 04:04
@solracsf solracsf added 3. to review Waiting for reviews feature: ldap labels Jun 28, 2025
@solracsf solracsf added this to the Nextcloud 32 milestone Jun 28, 2025
@come-nc
Copy link
Contributor

come-nc commented Jun 30, 2025

@Mark-PAS Could you amend your commit to add a sign-off to please DCO?
You can use git option --signoff for that.

@Mark-PAS
Copy link
Contributor Author

@Mark-PAS Could you amend your commit to add a sign-off to please DCO? You can use git option --signoff for that.

Done.

@come-nc
Copy link
Contributor

come-nc commented Jul 3, 2025

Failures not related, good for force merge.

@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 3, 2025
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nickvergessen nickvergessen merged commit 1d43f6b into nextcloud:master Jul 14, 2025
176 of 182 checks passed
@welcome
Copy link

welcome bot commented Jul 14, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: ldap feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: "Undefined array key 0" when 'pwdpolicysubentry', 'pwdgraceusetime', 'pwdreset', 'pwdchangedtime' not exist

7 participants