Skip to content

chore/rector: make phpunit dataproviders phpunit 12 compatible #53728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icewind1991 merged 3 commits into from
Jul 2, 2025
Merged

chore/rector: make phpunit dataproviders phpunit 12 compatible #53728

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
259f1fe
chore: add phpunit StaticDataProviderClassMethodRector rector rule
icewind1991 Jun 30, 2025
1620a0c
chore: add rector DataProviderAnnotationToAttributeRector
icewind1991 Jun 30, 2025
aa15f9d
chore: run rector
icewind1991 Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: add phpunit StaticDataProviderClassMethodRector rector rule 
Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991
icewind1991 committed Jul 1, 2025
commit 259f1fe9bdf1e3437889f0d68914cee0a34cefe6
4 changes: 3 additions & 1 deletion build/rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use Rector\Config\RectorConfig;
use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
use Rector\PHPUnit\CodeQuality\Rector\MethodCall\UseSpecificWillMethodRector;
use Rector\PHPUnit\PHPUnit100\Rector\Class_\StaticDataProviderClassMethodRector;
use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType;
use Rector\ValueObject\Application\File;

Expand Down Expand Up @@ -81,7 +82,8 @@ public function shouldSkip(File $file, FullyQualifiedObjectType $fullyQualifiedO
->withImportNames(importShortClasses:false)
->withTypeCoverageLevel(0)
->withRules([
UseSpecificWillMethodRector::class
UseSpecificWillMethodRector::class,
StaticDataProviderClassMethodRector::class,
])
->withConfiguredRule(ClassPropertyAssignToConstructorPromotionRector::class, [
'inline_public' => true,
Expand Down