Skip to content

fix(comments): switch to outlined icons where possible #53776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Jul 4, 2025
Merged

fix(comments): switch to outlined icons where possible #53776

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6aaa853
fix(comments): switch to outlined icons where possible
edward-ly Jul 2, 2025
7d045f6
chore(assets): Recompile assets
nextcloud-command Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(comments): switch to outlined icons where possible 
Signed-off-by: Edward Ly <[email protected]>
  • Loading branch information
@edward-ly @susnux
edward-ly authored and susnux committed Jul 4, 2025
commit 6aaa853e14ceb5f8a0bc93510234255c65a32d53
12 changes: 6 additions & 6 deletions apps/comments/src/components/Comment.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@
<NcActionButton close-after-click
@click="onEdit">
<template #icon>
<IconEdit :size="20" />
<IconPencilOutline :size="20" />
</template>
{{ t('comments', 'Edit comment') }}
</NcActionButton>
<NcActionSeparator />
<NcActionButton close-after-click
@click="onDeleteWithUndo">
<template #icon>
<IconDelete :size="20" />
<IconTrashCanOutline :size="20" />
</template>
{{ t('comments', 'Delete comment') }}
</NcActionButton>
Expand Down Expand Up @@ -115,8 +115,8 @@ import NcUserBubble from '@nextcloud/vue/components/NcUserBubble'

import IconArrowRight from 'vue-material-design-icons/ArrowRight.vue'
import IconClose from 'vue-material-design-icons/Close.vue'
import IconDelete from 'vue-material-design-icons/Delete.vue'
import IconEdit from 'vue-material-design-icons/Pencil.vue'
import IconTrashCanOutline from 'vue-material-design-icons/TrashCanOutline.vue'
import IconPencilOutline from 'vue-material-design-icons/PencilOutline.vue'

import CommentMixin from '../mixins/CommentMixin.js'
import { mapStores } from 'pinia'
Expand All @@ -132,8 +132,8 @@ export default {
components: {
IconArrowRight,
IconClose,
IconDelete,
IconEdit,
IconTrashCanOutline,
IconPencilOutline,
NcActionButton,
NcActions,
NcActionSeparator,
Expand Down
18 changes: 9 additions & 9 deletions apps/comments/src/views/Comments.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
class="comments__empty"
:name="t('comments', 'No comments yet, start the conversation!')">
<template #icon>
<MessageReplyTextIcon />
<IconMessageReplyTextOutline />
</template>
</NcEmptyContent>
<ul v-else>
Expand Down Expand Up @@ -51,12 +51,12 @@
<template v-else-if="error">
<NcEmptyContent class="comments__error" :name="error">
<template #icon>
<AlertCircleOutlineIcon />
<IconAlertCircleOutline />
</template>
</NcEmptyContent>
<NcButton class="comments__retry" @click="getComments">
<template #icon>
<RefreshIcon />
<IconRefresh />
</template>
{{ t('comments', 'Retry') }}
</NcButton>
Expand All @@ -72,9 +72,9 @@ import { vElementVisibility as elementVisibility } from '@vueuse/components'

import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
import NcButton from '@nextcloud/vue/components/NcButton'
import RefreshIcon from 'vue-material-design-icons/Refresh.vue'
import MessageReplyTextIcon from 'vue-material-design-icons/MessageReplyText.vue'
import AlertCircleOutlineIcon from 'vue-material-design-icons/AlertCircleOutline.vue'
import IconRefresh from 'vue-material-design-icons/Refresh.vue'
import IconMessageReplyTextOutline from 'vue-material-design-icons/MessageReplyTextOutline.vue'
import IconAlertCircleOutline from 'vue-material-design-icons/AlertCircleOutline.vue'

import Comment from '../components/Comment.vue'
import CommentView from '../mixins/CommentView'
Expand All @@ -89,9 +89,9 @@ export default {
Comment,
NcEmptyContent,
NcButton,
RefreshIcon,
MessageReplyTextIcon,
AlertCircleOutlineIcon,
IconRefresh,
IconMessageReplyTextOutline,
IconAlertCircleOutline,
},

directives: {
Expand Down
Loading