Skip to content

[stable31] fix(files_versions): Log failure to compute node path #53782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 2 commits into from
Jul 3, 2025
Merged

[stable31] fix(files_versions): Log failure to compute node path #53782

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efd9991
fix(files_versions): Log failure to compute node path
come-nc Jun 3, 2025
5e25698
chore: Use an if/else instead of the try/catch to make meaning more o…
come-nc Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files_versions): Log failure to compute node path 
To avoid hidden bugs, add some debug logging when a node path cannot be
 computed from a received event, to have more information for debugging

Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc @backportbot
come-nc authored and backportbot[bot] committed Jul 3, 2025
commit efd9991e21d6bc6377bcfc3b589372c0bd4c34eb
18 changes: 18 additions & 0 deletions apps/files_versions/lib/Listener/FileEventsListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,24 @@ private function getPathForNode(Node $node): ?string {
}
}

try {
$this->logger->debug('Failed to compute path for node', [
'node' => [
'path' => $node->getPath(),
'owner' => $owner,
'fileid' => $node->getId(),
'size' => $node->getSize(),
'mtime' => $node->getMTime(),
]
]);
} catch (NotFoundException) {
$this->logger->debug('Failed to compute path for node', [
'node' => [
'path' => $node->getPath(),
'owner' => $owner,
]
]);
}
return null;
}
}