Skip to content

Conversation

@icewind1991
Copy link
Member

No need to check for user preferences if share_with isn't a user.

Fixes #53830

@icewind1991 icewind1991 added this to the Nextcloud 32 milestone Jul 7, 2025
@icewind1991 icewind1991 requested a review from a team as a code owner July 7, 2025 15:06
@icewind1991 icewind1991 requested review from Altahrim, leftybournes and provokateurin and removed request for a team July 7, 2025 15:06
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 7, 2025
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message also has a typo

@icewind1991 icewind1991 force-pushed the dont-check-share-folder-remote branch from f5b78e5 to 5a4faba Compare July 10, 2025 18:04
@provokateurin provokateurin enabled auto-merge July 11, 2025 07:32
This was referenced Aug 22, 2025
This was referenced Sep 2, 2025
This was referenced Sep 25, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@st3iny
Copy link
Member

st3iny commented Oct 6, 2025

Seems to be obsolete by now.

$shareFolder = $this->config->getSystemValue('share_folder', '/');
if ($share->getShareType() === IShare::TYPE_USER) {
$allowCustomShareFolder = $this->config->getSystemValueBool('sharing.allow_custom_share_folder', true);
if ($allowCustomShareFolder) {
$shareFolder = $this->config->getUserValue($share->getSharedWith(), Application::APP_ID, 'share_folder', $shareFolder);
}
}

Please reopen if I'm wrong.

@st3iny st3iny closed this Oct 6, 2025
auto-merge was automatically disabled October 6, 2025 11:39

Pull request was closed

@st3iny st3iny deleted the dont-check-share-folder-remote branch October 6, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: cannot remote share with federated cloud id longer than 64 characters

5 participants