Skip to content

Conversation

@miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Jul 7, 2025

Summary

Implements changes as discussed in nextcloud/spreed#15465

Close #54177

TODO

  • Vue Library update
  • frontender work to align modal

Checklist

@miaulalala miaulalala added this to the Nextcloud 32 milestone Jul 7, 2025
@miaulalala miaulalala self-assigned this Jul 7, 2025
@miaulalala miaulalala requested a review from st3iny as a code owner July 7, 2025 16:53
@miaulalala miaulalala added the 2. developing Work in progress label Jul 7, 2025
@miaulalala miaulalala requested review from come-nc, nfebe, nickvergessen, skjnldsv and szaimen and removed request for a team July 7, 2025 16:53
@szaimen szaimen removed their request for review July 8, 2025 10:14
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from technical side. The frontend needs some polishing thou 🙈

@Antreesy
Copy link
Contributor

Antreesy commented Jul 28, 2025

Pushing frontend changes:

Before After
2025-07-28_12h35_40 image

@Antreesy Antreesy self-assigned this Jul 28, 2025
@Antreesy Antreesy added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 28, 2025
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miaulalala miaulalala force-pushed the feat/noid/add-busy-status branch from 50518d8 to 8f9a633 Compare July 28, 2025 12:45
@nextcloud-command nextcloud-command requested a review from a team as a code owner July 28, 2025 14:44
@skjnldsv skjnldsv force-pushed the feat/noid/add-busy-status branch from 9dbaec1 to c58a752 Compare July 28, 2025 14:46
@skjnldsv
Copy link
Member

Failure related
image

@miaulalala miaulalala force-pushed the feat/noid/add-busy-status branch 3 times, most recently from 784fb28 to 9c96b1d Compare July 29, 2025 10:23
@miaulalala miaulalala force-pushed the feat/noid/add-busy-status branch from 9c96b1d to df2336c Compare July 31, 2025 13:08
@st3iny st3iny force-pushed the feat/noid/add-busy-status branch 2 times, most recently from 80fd1aa to df2336c Compare July 31, 2025 14:12
@Antreesy Antreesy force-pushed the feat/noid/add-busy-status branch from df2336c to 554d5e4 Compare July 31, 2025 18:03
@Antreesy
Copy link
Contributor

/compile

miaulalala and others added 2 commits August 1, 2025 08:35
- remove modal name
- propagate box-sizing
- reduce gap between sections 12px -> 8px
- align icons vertically
- add hover effect to status labels

Signed-off-by: Maksim Sukharev <[email protected]>
@nickvergessen nickvergessen force-pushed the feat/noid/add-busy-status branch from 36e02eb to 47923b9 Compare August 1, 2025 06:35
@nickvergessen
Copy link
Member

/compile

Signed-off-by: nextcloud-command <[email protected]>
@Antreesy Antreesy merged commit 1675aa4 into master Aug 1, 2025
207 of 209 checks passed
@Antreesy Antreesy deleted the feat/noid/add-busy-status branch August 1, 2025 07:09
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants