Skip to content

feat: add Context Chat OCP API #53859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edward-ly merged 6 commits into from
Jul 15, 2025
Merged

feat: add Context Chat OCP API #53859

edward-ly merged 6 commits into from
Jul 15, 2025

Conversation

@edward-ly
Copy link
Contributor

@edward-ly edward-ly commented Jul 8, 2025 •
edited
Loading

Checklist

@edward-ly edward-ly added this to the Nextcloud 32 milestone Jul 8, 2025
@edward-ly edward-ly added enhancement 3. to review Waiting for reviews php Pull requests that update Php code pending documentation This pull request needs an associated documentation update labels Jul 8, 2025
@edward-ly edward-ly requested a review from marcelklehr July 8, 2025 00:04
@edward-ly edward-ly force-pushed the feat/context-chat-ocp branch from 4dc4697 to 1290be2 Compare July 8, 2025 00:27
@marcelklehr
Copy link
Member

marcelklehr commented Jul 8, 2025

Looks good! You can suppress psalm errors for the OCA\ContextChat classes by adding them to the psalm.xml suppress handler.

@edward-ly edward-ly marked this pull request as ready for review July 8, 2025 15:11
@edward-ly edward-ly requested a review from a team as a code owner July 8, 2025 15:11
@edward-ly edward-ly requested review from icewind1991, sorbaugh and yemkareems and removed request for a team July 8, 2025 15:11
This was referenced Jul 8, 2025
Merged
Merged
kyteinsky
kyteinsky reviewed Jul 9, 2025
View reviewed changes
@edward-ly edward-ly force-pushed the feat/context-chat-ocp branch 2 times, most recently from 0291146 to ccbf226 Compare July 9, 2025 20:52
julien-nc
julien-nc requested changes Jul 11, 2025
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a isContextChatAvailable method in the content manager so providers could even avoid calling submitContent if it's not available.

There could be a new section in the docs (after "Submitting ContentItem data") about this new method.

@marcelklehr
Copy link
Member

marcelklehr commented Jul 11, 2025

Ah, yes. Good point. OCA\ContextChat\Public\ContentManager would also have to implement this, then, which is a bit useless, but we can just return true there.

julien-nc
julien-nc requested changes Jul 11, 2025
View reviewed changes
@edward-ly edward-ly mentioned this pull request Jul 11, 2025
Merged
@edward-ly edward-ly force-pushed the feat/context-chat-ocp branch from 6a256a8 to 87d4253 Compare July 11, 2025 17:57
@marcelklehr marcelklehr requested a review from julien-nc July 13, 2025 12:00
@marcelklehr marcelklehr force-pushed the feat/context-chat-ocp branch from 87d4253 to 70204ea Compare July 14, 2025 07:50
susnux
susnux reviewed Jul 14, 2025
View reviewed changes
@marcelklehr marcelklehr removed the pending documentation This pull request needs an associated documentation update label Jul 14, 2025
susnux
susnux reviewed Jul 14, 2025
View reviewed changes
ChristophWurst
ChristophWurst reviewed Jul 14, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

nickvergessen
nickvergessen reviewed Jul 14, 2025
View reviewed changes
nickvergessen
nickvergessen previously requested changes Jul 14, 2025
View reviewed changes
@edward-ly edward-ly force-pushed the feat/context-chat-ocp branch 2 times, most recently from c6efa0a to fe7561d Compare July 15, 2025 14:34
@nickvergessen nickvergessen dismissed their stale review July 15, 2025 14:35

Seems to work

@edward-ly edward-ly enabled auto-merge July 15, 2025 14:37
@edward-ly edward-ly force-pushed the feat/context-chat-ocp branch from fe7561d to aafcbcc Compare July 15, 2025 15:20
@edward-ly edward-ly merged commit 8210e12 into master Jul 15, 2025
222 of 228 checks passed
@edward-ly edward-ly deleted the feat/context-chat-ocp branch July 15, 2025 15:57
@marcelklehr
Copy link
Member

marcelklehr commented Jul 16, 2025

Awesome! Great work @edward-ly

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@marcelklehr marcelklehr marcelklehr approved these changes

@ChristophWurst ChristophWurst ChristophWurst left review comments

@susnux susnux susnux left review comments

@kyteinsky kyteinsky kyteinsky approved these changes

@julien-nc julien-nc julien-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Implement an OCP API for Context Chat

9 participants

@edward-ly @marcelklehr @nickvergessen @ChristophWurst @susnux @julien-nc @kyteinsky @skjnldsv