Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 9, 2025

See #53663
Created this for testing only

@skjnldsv skjnldsv requested a review from a team as a code owner July 9, 2025 14:12
@skjnldsv skjnldsv requested review from nfebe, susnux and szaimen and removed request for a team July 9, 2025 14:12
@skjnldsv
Copy link
Member Author

skjnldsv commented Jul 9, 2025

/compile rebase

@skjnldsv skjnldsv removed request for nfebe, susnux and szaimen July 9, 2025 14:12
kra-mo and others added 2 commits July 9, 2025 14:18
This setting is already present in the main view,
where it is much more visible, it is also the only one that is documented.
Having it in both places is redundant and unnecessary clutter.

Signed-off-by: kramo <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the remove-redundant-setting branch from cf0c1e1 to 7f38fdf Compare July 9, 2025 14:21
@nextcloud-command nextcloud-command requested a review from a team as a code owner July 9, 2025 14:21
@szaimen
Copy link
Contributor

szaimen commented Jul 9, 2025

See #53663 Created this for testing only

?

@skjnldsv
Copy link
Member Author

skjnldsv commented Jul 9, 2025

See #53663 Created this for testing only

?

Original PR is a fork, cypress doesn't work on forks. So I created the same here to ensure it passes before merging the original

@skjnldsv
Copy link
Member Author

skjnldsv commented Jul 9, 2025

I mean, we could also just merge this one 🤷

@susnux susnux removed the request for review from a team July 9, 2025 15:10
@skjnldsv skjnldsv merged commit 6cc5484 into master Jul 9, 2025
148 of 160 checks passed
@skjnldsv skjnldsv deleted the remove-redundant-setting branch July 9, 2025 17:27
@jancborchardt
Copy link
Member

Thanks a lot @skjnldsv @susnux and props @kra-mo for a merged improvement! :)

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants