Skip to content

fix(comments): Adjust interface with implementation #53904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Jul 11, 2025
Merged

fix(comments): Adjust interface with implementation #53904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/public/Comments/ICommentsManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ public function getForObject(
* @param int $limit optional, number of maximum comments to be returned. if
* set to 0, all comments are returned.
* @param bool $includeLastKnown
* @param string $topmostParentId Limit the comments to a list of replies and its original root comment
* @return list<IComment>
* @since 14.0.0
* @deprecated 24.0.0 - Use getCommentsWithVerbForObjectSinceComment instead
Expand All @@ -119,6 +120,7 @@ public function getForObjectSince(
string $sortDirection = 'asc',
int $limit = 30,
bool $includeLastKnown = false,
string $topmostParentId = '',
): array;

/**
Expand All @@ -130,6 +132,7 @@ public function getForObjectSince(
* @param int $limit optional, number of maximum comments to be returned. if
* set to 0, all comments are returned.
* @param bool $includeLastKnown
* @param string $topmostParentId Limit the comments to a list of replies and its original root comment
* @return list<IComment>
* @since 24.0.0
*/
Expand All @@ -141,6 +144,7 @@ public function getCommentsWithVerbForObjectSinceComment(
string $sortDirection = 'asc',
int $limit = 30,
bool $includeLastKnown = false,
string $topmostParentId = '',
): array;

/**
Expand Down
2 changes: 2 additions & 0 deletions tests/lib/Comments/FakeManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public function getForObjectSince(
string $sortDirection = 'asc',
int $limit = 30,
bool $includeLastKnown = false,
string $topmostParentId = '',
): array {
return [];
}
Expand All @@ -50,6 +51,7 @@ public function getCommentsWithVerbForObjectSinceComment(
string $sortDirection = 'asc',
int $limit = 30,
bool $includeLastKnown = false,
string $topmostParentId = '',
): array {
return [];
}
Expand Down
Loading