Skip to content

[stable31] fix: hide rename action in trashbin #53916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamza221 merged 4 commits into from
Jul 14, 2025
Merged

[stable31] fix: hide rename action in trashbin #53916

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e167dc1
fix: hide rename action is trashbin
hamza221 Jul 7, 2025
ce15c53
fix(files): allow renaming if parent allow creating
skjnldsv Jul 10, 2025
bb48b4b
fix: adapt rename action tests to check for parent permissions
hamza221 Jul 11, 2025
740c803
chore(assets): Recompile assets
nextcloud-command Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: hide rename action is trashbin 
Signed-off-by: Hamza <[email protected]>
  • Loading branch information
@hamza221 @backportbot
hamza221 authored and backportbot[bot] committed Jul 11, 2025
commit e167dc1dd7ac19ee1f98675a3e612ff5320781cc
2 changes: 1 addition & 1 deletion apps/files/src/actions/renameAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const action = new FileAction({
return false
}
// Only enable if all nodes have the delete permission
return nodes.every((node) => Boolean(node.permissions & Permission.DELETE))
return nodes.every((node) => Boolean(node.permissions & Permission.DELETE) && Boolean(node.permissions & Permission.UPDATE))
},

async exec(node: Node) {
Expand Down